-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Split up the socket mode from the socket path #10581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the screengrab things look a little out to me, not sure what's going on there?
Yea, I'm not sure. I'm not making any changes to spacing in this PR though. @johncowen |
@johncowen fixed the issue and update the screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sorting that issue and adding the updated screengrab.
I've added another couple of tiny comments.
Apart from that, I'm ok for you to look at the spacing here or in another PR. It's completely up to you, but from what I remember back when the team decided to squash commits for PRs, it was so we don't end up adding lots of tiny commits to the git history that probably weren't relevant to folks. I think it's handy for everything to go in under the same meaningful change/changelog but either way here I think is fine.
I wrote some docs on how to style these things here https://consul-ui-staging-hashicorp.vercel.app/ui/docs/components/horizontal-kv-list if it helps, if you hit any problems doing that let me know, I'd be happy to go through together.
ui/packages/consul-ui/app/components/consul/upstream-instance/list/index.hbs
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/upstream-instance/list/index.hbs
Outdated
Show resolved
Hide resolved
40fe2d1
to
0591e4c
Compare
ui/packages/consul-ui/app/components/consul/upstream-instance/list/index.hbs
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/upstream-instance/list/index.hbs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't see my last comment in the Conversation view, I tried un-resolving it but that didn't effect anything, here's a link to it instead
https://github.com/hashicorp/consul/pull/10581/files#r673248452
🤞 it shows up in the Convo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I think this looks great! I think the only thing that may help this PR now would be to make another edit to the description to add a new screengrab to show how we finished it up.
Other than that LGTM!
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/425533. |
🍒✅ Cherry pick of commit ab6a675 onto |
When there is no
LocalBindSocketMode
:With a
LocalBindSocketMode
: